Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThis pull request is a version release bump from 0.9.0 to 0.9.1 across the SDK. Changes include updating the CHANGELOG with release notes documenting new features (streamed list objects support and client interface), incrementing the version constant in the SDK, bumping the package version in the project files, and updating the example project dependency. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@example/Example1/Example1.csproj`:
- Around line 13-15: Update the PackageReference for the OpenFga.Sdk dependency
so the project can restore: change the Version attribute on the PackageReference
element that includes "OpenFga.Sdk" from "0.9.1" to the published "0.9.0" (i.e.,
update the PackageReference Include="OpenFga.Sdk" Version value to "0.9.0" while
keeping <PrivateAssets>all</PrivateAssets> intact).
There was a problem hiding this comment.
Pull request overview
This is a release PR that bumps the SDK version from 0.9.0 to 0.9.1, documenting the addition of two new features to the OpenFGA .NET SDK.
Changes:
- Updated version number from 0.9.0 to 0.9.1 across the SDK project file, constants, and example project
- Added v0.9.1 changelog entry documenting support for streamed list objects and client interface
- Updated the Unreleased section in CHANGELOG.md to compare against v0.9.1
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/OpenFga.Sdk/OpenFga.Sdk.csproj | Updated package version to 0.9.1 |
| src/OpenFga.Sdk/Constants/FgaConstants.cs | Updated SDK version constant and user agent string to 0.9.1 |
| example/Example1/Example1.csproj | Updated package reference to use version 0.9.1 |
| CHANGELOG.md | Added v0.9.1 release section and updated Unreleased comparison link |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
I'm good with the changes - but before we merge and release, I just want to ping @OsmanMElsayed @OsmanMElsayed this is included. I know this previously caused issues for you causing you to submit this PR.
|
|
@OsmanMElsayed - we will release as is. If this causes issues on your end, please raise an issue and we can try to reach a solution that is both maintainable and works for folks. |
Thank you @rhamzeh for tagging me <3 and sorry for the late reply (I'm on paternity leave). Will check and let you know as soon as I'm back. And it was a good ideaa to release, for sure we will find a common ground solution if need be :). |
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.