Skip to content

Conversation

@ewanharris
Copy link
Member

@ewanharris ewanharris commented Nov 5, 2025

Description

## [0.7.8] - 2025-11-05

Fixed:
- Fix path resolution in `fga model test` to no longer resolve paths using the files base path

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

  • Documentation
    • Updated changelog with version 0.7.8 release notes, documenting a fix for path resolution handling in FGA model tests.

Copilot AI review requested due to automatic review settings November 5, 2025 15:24
@ewanharris ewanharris requested a review from a team as a code owner November 5, 2025 15:24
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 5, 2025

Walkthrough

This PR updates CHANGELOG.md to document a fix in version 0.7.8 addressing path resolution behavior in fga model tests, where test file paths no longer resolve using the file's base path.

Changes

Cohort / File(s) Summary
Changelog documentation
CHANGELOG.md
Added version 0.7.8 (2025-11-05) release entry documenting the fix to model test path resolution; added comparison link for the release

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

This is a straightforward changelog documentation update with no code logic changes or modifications to public APIs.

Possibly related PRs

  • release: v0.7.6 #596: Documents the same fix to model test path resolution, providing context for the behavior change being documented in this changelog entry.

Suggested reviewers

  • sergiught
  • jimmyjames

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'release: v0.7.8' directly describes the pull request's main objective—creating a release for version 0.7.8. It is concise, clear, and specific, matching the changelog entry and PR objectives.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch release/v0.7.8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a changelog entry for version 0.7.8, documenting a bug fix related to path resolution in the fga model test command. The fix addresses an issue where paths were incorrectly being resolved using the file's base path.

  • Added version 0.7.8 changelog entry with release date 2025-11-05
  • Documented the path resolution bug fix in fga model test
  • Updated version comparison link at the bottom of the changelog

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ewanharris ewanharris added this pull request to the merge queue Nov 5, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db7dfeb and 48173ef.

📒 Files selected for processing (1)
  • CHANGELOG.md (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Tests
🔇 Additional comments (1)
CHANGELOG.md (1)

359-359: Comparison link format is correct.

The v0.7.8 comparison link is properly formatted and follows the established pattern used throughout the changelog.

Comment on lines +10 to +13
## [0.7.8] - 2025-11-05

Fixed:
- Fix path resolution in `fga model test` to no longer resolve paths using the files base path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Add PR and issue references for traceability.

The v0.7.8 changelog entry lacks PR and issue references, which is inconsistent with other entries in the changelog. For example, the v0.7.7 entry (line 30) includes ([#516](https://github.com/openfga/cli/pull/516)) - fixes #349 for similar path resolution fixes.

Can you provide the PR number and related issue number for this fix so we can add them to the changelog entry? The format should match existing entries:

-Fix path resolution in `fga model test` to no longer resolve paths using the files base path
+Fix path resolution in `fga model test` to no longer resolve paths using the files base path ([#XXX](https://github.com/openfga/cli/pull/XXX)) - fixes #YYY

Additionally, clarify whether this fix corrects a regression from v0.7.7's path resolution changes or is a separate improvement.


🏁 Script executed:

#!/bin/bash
# Search for v0.7.8 related commits and tags
echo "=== Git tags for v0.7.8 ==="
git tag | grep -i "v0.7.8" || echo "No exact tag found"

echo -e "\n=== Recent git log entries mentioning 0.7.8 or path resolution ==="
git log --oneline --all -50 | grep -i "0.7.8\|path\|fga model test" || echo "No matches in recent history"

echo -e "\n=== Search git log for path resolution fixes ==="
git log --oneline --all -100 --grep="path\|fga model test" || echo "No matches found"

echo -e "\n=== Check for PR references in CHANGELOG commits ==="
git log -p --all -- CHANGELOG.md | grep -A5 -B5 "0.7.8" | head -40

Length of output: 1023


🏁 Script executed:

#!/bin/bash
# Search the codebase for references to PR numbers or issue numbers near v0.7.8
echo "=== Search CHANGELOG for nearby PR/issue patterns ==="
rg -n -A3 -B3 "0.7.8|path resolution" CHANGELOG.md

echo -e "\n=== Look for issue or PR references in git branch/commit names ==="
git branch -a | grep -i "v0.7.8\|path\|fix" | head -10

echo -e "\n=== Check recent tags for release dates ==="
git tag -l "v0.7.*" --format='%(refname:short) %(creatordate:short)' 2>/dev/null | tail -10

Length of output: 1097


🏁 Script executed:

#!/bin/bash
# Get the full commit message for the v0.7.8 fix
echo "=== Full commit message for db7dfeb ==="
git log -1 --format=%B db7dfeb

echo -e "\n=== Search commit history for PR #603 or issue references ==="
git log --oneline --all --grep="#603\|PR 603" | head -10

echo -e "\n=== Get commits between v0.7.7 release and v0.7.8 release ==="
git log --oneline 7266fff...48173ef | head -20

Length of output: 372


🌐 Web query:

Does GitHub PR #603 in openfga/cli repository contain issue references?

💡 Result:

Yes — the PR's References section includes a reference to openfga/action-openfga-test#32. [1]


Add PR #603 reference to changelog entry.

Verification confirms that the v0.7.8 entry should reference PR #603 which contains the fix commit. Additionally, PR #603 references openfga/action-openfga-test#32, though this is a cross-repository issue reference.

Update the v0.7.8 changelog entry to:

-Fix path resolution in `fga model test` to no longer resolve paths using the files base path
+Fix path resolution in `fga model test` to no longer resolve paths using the files base path ([#603](https://github.com/openfga/cli/pull/603))

If the cross-repository issue should be included, adjust the format accordingly since it references a different repository.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## [0.7.8] - 2025-11-05
Fixed:
- Fix path resolution in `fga model test` to no longer resolve paths using the files base path
## [0.7.8] - 2025-11-05
Fixed:
- Fix path resolution in `fga model test` to no longer resolve paths using the files base path ([#603](https://github.com/openfga/cli/pull/603))
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 10 to 13, the v0.7.8 entry is missing the PR
reference; update the line "Fix path resolution in `fga model test` to no longer
resolve paths using the files base path" to append " (PR #603)" and, if
including the cross-repository issue, add " — fixes
openfga/action-openfga-test#32" using that cross-repo issue format so the
changelog references PR #603 and optionally the external issue.

Merged via the queue into main with commit 57ff47b Nov 5, 2025
25 of 28 checks passed
@ewanharris ewanharris deleted the release/v0.7.8 branch November 5, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants