fix: prevent path duplication in model test command

[aaguiarz]

This fixes the issue reported in:
openfga/action-openfga-test#32

The bug occurred when the CLI v0.7.7 changed how the --tests parameter resolves paths. The model test command was passing both:

• fileName: the full path from glob (e.g., "my_project/infrastructure/fga/tests.fga.yaml")
• basePath: path.Dir(fileName) (e.g., "my_project/infrastructure/fga")

This caused ReadFromFile to join them, creating a duplicated path: "my_project/infrastructure/fga/my_project/infrastructure/fga/tests.fga.yaml"

The fix passes an empty basePath since the file path from glob is already complete. ReadFromFile now correctly uses the file's directory internally for resolving nested file references (model_file, tuple_file).

Changes:

• Modified cmd/model/test.go to pass empty basePath to ReadFromFile
• Added comprehensive unit tests in internal/storetest/read-from-input_test.go that verify the fix and prevent regression

Description

What problem is being solved?

How is it being solved?

What changes are made to solve it?

References

Review Checklist

• I have clicked on "allow edits by maintainers".
• I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
• The correct base branch is being used, if not main
• I have added tests to validate that the change in functionality is working as expected

Summary by CodeRabbit

• Bug Fixes

  • Resolved path resolution issue that was causing incorrect path duplication in file handling.

• Tests

  • Added comprehensive test coverage for file path resolution scenarios, including nested file references and error messaging.

[linux-foundation-easycla]

• ✅ login: Copilot / name: Copilot (7595ed7)
• ✅ login: Siddhant-K-code / name: Siddhant Khare (7595ed7)
• ❌ - login: @claude / name: Claude. The commit (ceaab4f) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[coderabbitai]

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The PR fixes path duplication in test file resolution by changing how ReadFromFile combines the base path and file name. A new test file is added to validate the path resolution behavior under various scenarios, including the previous duplication bug and correct handling of empty, relative, and absolute paths.

Changes

Cohort / File(s)	Summary
Test configuration update cmd/model/test.go	Modifies the basePath argument passed to storetest.ReadFromFile from path.Dir(file) to an empty string, preventing path duplication when resolving nested test file references.
Path resolution test suite internal/storetest/read-from-input_test.go	Adds comprehensive test coverage for ReadFromFile path resolution behavior, including tests for duplication prevention, empty basePath handling, absolute path resolution, nested references, and error message quality.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• The actual code change is minimal (single argument replacement in one file)
• New test file is straightforward with clear test scenarios
• No complex logic or structural changes involved
• Verify test cases adequately cover the path resolution edge cases mentioned

Possibly related PRs

• PR #516: Modifies ReadFromFile's path-resolution behavior for how basePath and fileName are combined and opened.
• PR #515: Adjusts test file resolution in cmd/model/test.go and adds glob-based file resolution capabilities.

Suggested labels

codex

Suggested reviewers

• rhamzeh
• sergiught
• Siddhant-K-code

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main fix: preventing path duplication in the model test command by changing how basePath is passed to ReadFromFile.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull Request Overview

This PR fixes a path duplication bug in the model test command where passing path.Dir(file) as the basePath parameter to ReadFromFile caused the path to be joined incorrectly, creating duplicated paths like "path/to/file/path/to/file/test.yaml". The fix passes an empty basePath instead, allowing ReadFromFile to use the file's directory internally for resolving nested file references.

Key changes:

• Modified cmd/model/test.go to pass an empty string as basePath to ReadFromFile
• Added comprehensive test coverage in internal/storetest/read-from-input_test.go to validate the fix and prevent regression

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
cmd/model/test.go	Changed ReadFromFile call to pass empty basePath instead of path.Dir(file), with detailed explanation comment
internal/storetest/read-from-input_test.go	New test file covering path resolution scenarios including the bug case, correct usage with empty basePath, absolute paths, nested references, and error messages

Comments suppressed due to low confidence (1)

cmd/model/test.go:22

• The path package import on line 22 is no longer used after removing the path.Dir(file) call. This import should be removed to keep the imports clean.

	"path"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Siddhant-K-code]

@copilot can you fix the lint issues pls!

[Copilot]

@Siddhant-K-code I've opened a new pull request, #602, to work on those changes. Once the pull request is ready, I'll request review from you.

[Siddhant-K-code]

/easycla

[Siddhant-K-code]

Ahh, we wanted to get the claude get whitelisted for EasyCLA

[ewanharris]

Fixed in #603