-
Notifications
You must be signed in to change notification settings - Fork 38
chore(ci): downgrade cosign to v2.6.1 due to goreleaser incompatibility #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughThe goreleaser GitHub Actions workflow now pins Cosign to version v2.6.1 by adding the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR pins the cosign release version to v2.6.1 in the goreleaser workflow job.
- Adds explicit version specification for cosign in the signing step
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/main.yaml (1)
263-276: Consider applying the same cosign version pin to the verification job.The
verification-with-cosignjob at line 275 also usessigstore/cosign-installer, but it does not specify a version pin. If the installer defaults to cosign v3+, this verification step may face the same incompatibility issues or fail unexpectedly. For consistency and to avoid potential runtime issues, consider pinning cosign to v2.6.1 here as well.Apply this diff to align with the goreleaser job's version pin:
- name: Install Cosign uses: sigstore/cosign-installer@faadad0cce49287aee09b3a48701e75088a2c6ad # v4.0.0 + with: + cosign-release: "v2.6.1"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/main.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test Release Process
- GitHub Check: Tests
🔇 Additional comments (1)
.github/workflows/main.yaml (1)
157-160: Cosign downgrade applied to the goreleaser job.The change correctly pins cosign to v2.6.1 in the goreleaser step, addressing the incompatibility with cosign v3 noted in issue #597.
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
closes #597
Review Checklist
mainSummary by CodeRabbit