Draft
Conversation
|
|
recharte
reviewed
Feb 4, 2026
Contributor
recharte
left a comment
recharte
left a comment
There was a problem hiding this comment.
Hi @till thanks for driving this initiative, overall the changes look to be heading in the right direction. I still need to spend some more time with pg_repos_reconciler.go to make sure everything is fine.
Also, it would be great if you could extend the integration tests with these new cases. You'll see Makefile targets that will help you run those integration tests
related: #1821
…nstead of repo name
the backupStorageName function was causing nil pointer dereference crashes when processing Azure backups because it assumed all repos were S3 storage. updated to check storage type and match appropriate fields for both S3 and Azure storage types. added unit tests to verify correct behavior for S3, Azure, namespace mismatch, and error cases.
till
force-pushed
the
use-pod-or-workload-identity
branch
from
cf4e13b to
f763334
Compare
Author
|
@recharte I'd pick this up again in April and see if Percona updated pgbackrest, did you have any feedback? |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pgbackrest 2.58.0 was released a couple of days ago and adds support for managed identities. I briefly tested if it was already available in the percona repository:
# rebuild the image in percona-docker: docker run --rm -it till/percona-pgbackrest:latest bash bash-5.1$ pgbackrest version pgBackRest 2.57.0Generally, not sure what the procedure is to get the images rebuild in percona-docker (once it is available).
CHANGE DESCRIPTION
Problem:
EVEREST-0
Short explanation of the problem.
I want to use workload identity so that we don't have to maintain credentials for backups.
Related pull requests
Cause:
Maintaining and rotating credentials is a nightmare.
Solution:
The solution is (hopefully) this PR as it adds the feature for Azure and AWS.
CHECKLIST
Helm chart
Jira
Tests