Apply pre-commit hooks to entire codebase #1327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please wait with this until #1344 is merged. I had to resolve quite a lot of the erros manually to be able to commit. Seems like some of them are not picked up here. It was mostly commends with exceeding line as well as unused imports which could not be solved by pre commit. |
Member
Author
|
This was just for testing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test PR to see changes from running
pre-commit run -a.Still, about 1000 (yes!) errors remain that, with the current settings, cannot be resolved automatically. 90% are too long lines (flake8 and black are set to 79), we also have indentation errors and some unused imports.
Still, the changes in this PR would improve the quality and readability.