-
Notifications
You must be signed in to change notification settings - Fork 4
feat: pdf block #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pdf block #145
Conversation
|
Thanks for the pull request, @Kelketek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
160e78a to
5b7aaef
Compare
58d79f1 to
45aeb7a
Compare
|
@samuelallan72 This is ready for you! |
samuelallan72
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kelketek what revision are we pulling from? Just noting that we maintain two branches of https://github.com/open-craft/xblock-pdf : wgu-release and master, so we should try to reconcile changes in both to avoid losing any functionality.
| """ | ||
| Check if all downloads are disabled or not | ||
| """ | ||
| return getattr(settings, 'PDFXBLOCK_DISABLE_ALL_DOWNLOAD', False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a place in this repo to document each individual xblock? This setting was documented on the original source readme, but there doesn't seem to be an equivalent here.
We also should document how to install and use the xblock.
|
@Kelketek I couldn't get this xblock to display in Authoring... I installed the project in the devstack environment and added |
|
@samuelallan72 Whoops! I gathered the instructions for installing the block but forgot to actually put them in the description. They've been added now. You have to do some chicanery due to the fact that this package is a preinstalled one. |
a9c1357 to
0229d6a
Compare
0229d6a to
3dd224c
Compare
Overview
This merge request pulls the PDF block in, extracted from a third party plugin. For now, it does not use its intended block name (
pdf), and instead uses a temporary one (_pdf_extracted) as there's more work to do in order to fulfill the scope of the PDF Block Proposal. Once this work is completed, it will be renamed topdfand be considered generally available.Some minor alterations have been made to the block in order to allow it to be added to the contribs repository. These include the addition of tests, the migration from xblock_utils to xblock.utils, cleanup of lint issues and some spot improvements to docstrings. Otherwise, functionality has been largely left unchanged as this is the first part of the proposal-- moving the block into the contribs library.
Supporting information
Testing Instructions
tutor dev dc exec -it lms -- /bin/bashpip install -e git+https://github.com/open-craft/xblocks-contrib.git@fox/xblock-pdf#egg=xblocks_contribtutor dev dc exec -it cmd -- /bin/bashpip install -e git+https://github.com/open-craft/xblocks-contrib.git@fox/xblock-pdf#egg=xblocks_contrib"_pdf_extracted"to the list of advanced blocks.Deadlines
This should preferably be merged within the next couple of weeks so that other work depending on it is not blocked. The PDF Block proposal implementation is slated for Verawood.
Author Concerns
This block is fully functional, and while a large number of instances have installed it, it's not part of the standard and it might work just as well to immediately give it its intended name,
pdf, and then focus on the changes to the authoring interface (which will likely be added to the frontend authoring MFE), allowing the current interface to be used until this is ready.Merge checklist:
Check off if complete or not applicable: