Skip to content

Conversation

@Kelketek
Copy link

@Kelketek Kelketek commented Jan 23, 2026

Overview

This merge request pulls the PDF block in, extracted from a third party plugin. For now, it does not use its intended block name (pdf), and instead uses a temporary one (_pdf_extracted) as there's more work to do in order to fulfill the scope of the PDF Block Proposal. Once this work is completed, it will be renamed to pdf and be considered generally available.

Some minor alterations have been made to the block in order to allow it to be added to the contribs repository. These include the addition of tests, the migration from xblock_utils to xblock.utils, cleanup of lint issues and some spot improvements to docstrings. Otherwise, functionality has been largely left unchanged as this is the first part of the proposal-- moving the block into the contribs library.

Supporting information

Testing Instructions

  1. Bring up a standard modern tutor devstack installation
  2. Rather than adding this as a requirement in the config, we must install it manually due to conflicts in the installation order:
    1. Enter the LMS with tutor dev dc exec -it lms -- /bin/bash
    2. Install the package with pip install -e git+https://github.com/open-craft/xblocks-contrib.git@fox/xblock-pdf#egg=xblocks_contrib
    3. Exit the shell and then enter the CMS shell with tutor dev dc exec -it cmd -- /bin/bash
    4. Install the package with pip install -e git+https://github.com/open-craft/xblocks-contrib.git@fox/xblock-pdf#egg=xblocks_contrib
  3. In a course, enter the advanced settings and add "_pdf_extracted" to the list of advanced blocks.
  4. In the authoring interface, click on the advanced modules and select the PDF Block.
  5. Edit and play with it.

Deadlines

This should preferably be merged within the next couple of weeks so that other work depending on it is not blocked. The PDF Block proposal implementation is slated for Verawood.

Author Concerns

This block is fully functional, and while a large number of instances have installed it, it's not part of the standard and it might work just as well to immediately give it its intended name, pdf, and then focus on the changes to the authoring interface (which will likely be added to the frontend authoring MFE), allowing the current interface to be used until this is ready.

Merge checklist:
Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 23, 2026
@openedx-webhooks
Copy link

Thanks for the pull request, @Kelketek!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jan 23, 2026
@Kelketek Kelketek force-pushed the fox/xblock-pdf branch 5 times, most recently from 160e78a to 5b7aaef Compare January 26, 2026 18:29
@Kelketek
Copy link
Author

@samuelallan72 This is ready for you!

Copy link

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kelketek what revision are we pulling from? Just noting that we maintain two branches of https://github.com/open-craft/xblock-pdf : wgu-release and master, so we should try to reconcile changes in both to avoid losing any functionality.

"""
Check if all downloads are disabled or not
"""
return getattr(settings, 'PDFXBLOCK_DISABLE_ALL_DOWNLOAD', False)
Copy link

@samuelallan72 samuelallan72 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a place in this repo to document each individual xblock? This setting was documented on the original source readme, but there doesn't seem to be an equivalent here.

We also should document how to install and use the xblock.

@samuelallan72
Copy link

@Kelketek I couldn't get this xblock to display in Authoring... I installed the project in the devstack environment and added _pdf_extracted to the advanced module list. I couldn't see any obvious errors in the logs either. 🤔

@Kelketek
Copy link
Author

@samuelallan72 Whoops! I gathered the instructions for installing the block but forgot to actually put them in the description. They've been added now. You have to do some chicanery due to the fact that this package is a preinstalled one.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jan 27, 2026
@Kelketek Kelketek closed this Jan 27, 2026
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Jan 27, 2026
@Kelketek Kelketek mentioned this pull request Jan 28, 2026
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants