refactor: run tests with node:test #4044
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates changing a few tests to run using Node's Test Runner instead of jest.
Running the tests with Node's native test runner is much faster than running them with Jest, but does not support some of the non-standard imports we're currently using like importing SCSS and SVG files into Paragon. I've tried getting them to work using things like
@nodejs-loaders/mediato support importing SVG files, and that does work but it conflicts with thetsxloader that we need to support TSX/JSX syntax. So I'm not sure we can use this approach to testing without major refactoring.It also doesn't support Jest test syntax so many test cases have to be changed, although in a systematic way. (e.g.
expect(tree).toMatchSnapshot();->t.assert.snapshot(tree);). This is a big disadvantage compared to Vitest.Time taken to run
npm test -- src/Button/Button*.test.tsx:node:test