Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions cms/lib/xblock/tagging/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import ddt
from django.test.client import RequestFactory
from lxml import etree
from opaque_keys.edx.asides import AsideUsageKeyV1, AsideUsageKeyV2
from opaque_keys.edx.asides import AsideUsageKeyV1, AsideUsageKeyV2, UsageKey
from pytz import UTC
from xblock.fields import ScopeIds
from xblock.runtime import DictKeyValueStore, KvsFieldData
Expand Down Expand Up @@ -118,10 +118,12 @@ def test_aside_contains_tags(self):
"""
Checks that available_tags list is not empty
"""
sids = ScopeIds(user_id="bob",
block_type="bobs-type",
def_id="definition-id",
usage_id="usage-id")
sids = ScopeIds(
user_id="bob",
block_type="bobs-type",
def_id="definition-id",
usage_id=UsageKey.from_string("block-v1:myOrg+myCourse+myRun+type@bobs-type+block@usage-id"),
)
key_store = DictKeyValueStore()
field_data = KvsFieldData(key_store)
runtime = TestRuntime(services={'field-data': field_data})
Expand Down
4 changes: 2 additions & 2 deletions openedx/core/djangoapps/xblock/runtime/runtime.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from xblock.exceptions import NoSuchServiceError
from xblock.field_data import DictFieldData, FieldData, SplitFieldData
from xblock.fields import Scope, ScopeIds
from xblock.runtime import IdReader, KvsFieldData, MemoryIdManager, Runtime
from xblock.runtime import IdReader, KvsFieldData, Runtime

from xmodule.errortracker import make_error_tracker
from xmodule.contentstore.django import contentstore
Expand Down Expand Up @@ -127,7 +127,7 @@ def __init__(
),
default_class=None,
select=None,
id_generator=MemoryIdManager(), # We don't really use id_generator until we need to support asides
id_generator=None, # We won't need an id_generator until we need to support asides
)
assert student_data_mode in (StudentDataMode.Ephemeral, StudentDataMode.Persisted)
self.authored_data_mode = authored_data_mode
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/base.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1241,7 +1241,7 @@ wheel==0.45.1
# via django-pipeline
wrapt==2.0.1
# via -r requirements/edx/kernel.in
xblock[django]==5.3.0
git+https://github.com/kdmccormick/XBlock.git@kdmccormick/scope-id-types#egg=xblock[django]==6.0.0
# via
# -r requirements/edx/kernel.in
# acid-xblock
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/development.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2264,7 +2264,7 @@ wrapt==2.0.1
# via
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
xblock[django]==5.3.0
git+https://github.com/kdmccormick/XBlock.git@kdmccormick/scope-id-types#egg=xblock[django]==6.0.0
# via
# -r requirements/edx/doc.txt
# -r requirements/edx/testing.txt
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/doc.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1582,7 +1582,7 @@ wheel==0.45.1
# django-pipeline
wrapt==2.0.1
# via -r requirements/edx/base.txt
xblock[django]==5.3.0
git+https://github.com/kdmccormick/XBlock.git@kdmccormick/scope-id-types#egg=xblock[django]==6.0.0
# via
# -r requirements/edx/base.txt
# acid-xblock
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/testing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1672,7 +1672,7 @@ wheel==0.45.1
# django-pipeline
wrapt==2.0.1
# via -r requirements/edx/base.txt
xblock[django]==5.3.0
git+https://github.com/kdmccormick/XBlock.git@kdmccormick/scope-id-types#egg=xblock[django]==6.0.0
# via
# -r requirements/edx/base.txt
# acid-xblock
Expand Down
Loading