Skip to content

Conversation

@pomegranited
Copy link
Contributor

@pomegranited pomegranited commented Mar 16, 2025

Adds:

  • get_containers -- needed by content search API.
  • get_container_by_key -- reduces queries performed by content libraries API

And increases test coverage for the units API.

Builds on #278
Testing instructions: see openedx/edx-platform#36371

@openedx-webhooks
Copy link

Thanks for the pull request, @pomegranited!

This repository is currently maintained by @axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Mar 17, 2025
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @pomegranited!

  • I tested this using the instructions from openedx/edx-platform#36371
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Copy link
Contributor

@navinkarkera navinkarkera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pomegranited 👍 Looks good.

  • I tested this: (describe what you tested)
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@pomegranited pomegranited changed the title feat: adds get_containers and get_units to the authoring API [FC-0083] feat: adds get_containers and get_container_by_key to the authoring API [FC-0083] Mar 18, 2025
@pomegranited
Copy link
Contributor Author

@ormsbee @kdmccormick FYI for these added API methods, and a possible addition to the Container model, if you agree.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Mar 19, 2025
@pomegranited pomegranited merged commit 9adaaf6 into openedx:main Mar 19, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Mar 19, 2025
@pomegranited pomegranited deleted the jill/containers-api branch March 19, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants