Skip to content

Conversation

@AntonOfTheWoods
Copy link

Update outdated readme

@openedx-webhooks
Copy link

Thanks for the pull request, @AntonOfTheWoods!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 10, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Dec 10, 2025
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 11, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Dec 11, 2025
@e0d
Copy link

e0d commented Dec 11, 2025

@AntonOfTheWoods not sure why there's a failed test on this PR, potentially flaky test. Can you check if a rebase help?

@AntonOfTheWoods
Copy link
Author

thanks @e0d . Like with frontend-app-account, I'm above master here too. Should I rebase on something else? Contrary to frontend-app-account, here I can run the tests locally, and this does look like a flakey test (with the typical impossible/meaningless flakey test error!).

@e0d
Copy link

e0d commented Dec 12, 2025

@AntonOfTheWoods It looks like there's an npm issue that didn't fail on the last commit to master, but is failing now.

https://github.com/openedx/frontend-app-communications/actions/runs/20090744209/job/57855500474#step:5:9

I don't have time to test now, but I wonder if this would be an issue on master now because of some issue with a dependency. I can take a closer look tomorrow.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 12, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

4 participants