Skip to content

Conversation

@dcoa
Copy link
Contributor

@dcoa dcoa commented Feb 27, 2025

Warning

This PR should not be merge to master directly, it should point to master-design-tokens once the branch has been created.

Description
This PR updates frontend app communications to support CSS variables and the corresponding paragon design tokens.

Changes implemented:

  • Replace Paragon SCSS variables with CSS variables.
  • Update frontend-build with a version compatible

How to test

  1. In your environment add the settings to enable bulk email
  2. Access to the MFE from the course > instructor > email tab

@openedx-webhooks
Copy link

openedx-webhooks commented Feb 27, 2025

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 27, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Feb 27, 2025
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from fa2fd73 to 17403c3 Compare February 27, 2025 23:24
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 3, 2025
@dcoa dcoa added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Mar 18, 2025
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.02%. Comparing base (ad19426) to head (9281fa9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #217   +/-   ##
=======================================
  Coverage   84.02%   84.02%           
=======================================
  Files          47       47           
  Lines         695      695           
  Branches      133      133           
=======================================
  Hits          584      584           
  Misses        111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 3dbcf67 to 20dfa6a Compare March 18, 2025 22:35
return { loggingService, i18nService, authService };
}

jest.mock('@edx/frontend-platform/react/hooks', () => ({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated

@dcoa dcoa marked this pull request as ready for review March 25, 2025 06:11
@dcoa dcoa requested a review from brian-smith-tcril March 25, 2025 06:11
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 20dfa6a to 164fc56 Compare March 31, 2025 04:52
@dcoa dcoa changed the title [WIP] feat: support design tokens and paragon 23 feat: support design tokens and paragon 23 Mar 31, 2025
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 164fc56 to 9281fa9 Compare April 11, 2025 04:39
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brian-smith-tcril brian-smith-tcril changed the base branch from master to master-design-tokens April 11, 2025 16:09
@brian-smith-tcril brian-smith-tcril merged commit bbf254e into openedx:master-design-tokens Apr 11, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants