refactor: remove pointless maintenance link message #1503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This link is defined in frontend-component-header, so the message shouldn't be here. Anyway, we are deleting the link from frontend-component-header too.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1503 +/- ##
==========================================
- Coverage 93.28% 93.02% -0.26%
==========================================
Files 1052 1048 -4
Lines 20503 20493 -10
Branches 4385 4406 +21
==========================================
- Hits 19126 19064 -62
- Misses 1317 1359 +42
- Partials 60 70 +10 ☔ View full report in Codecov by Sentry. |
feanil
approved these changes
Nov 15, 2024
Member
Author
|
Codecov failure is unrelated to this change |
kdmccormick
added a commit
that referenced
this pull request
Jan 14, 2025
This reverts commit 6ffdb01.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This link is defined in frontend-component-header, so the message shouldn't be here. Anyway, we are deleting the link from frontend-component-header too, as the app is being removed from edx-platform.