-
Notifications
You must be signed in to change notification settings - Fork 178
Add Hungarian site language #1396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request, @dlakatos847! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Submit a signed contributor agreement (CLA)
If you've signed an agreement in the past, you may need to re-sign. Once you've signed the CLA, please allow 1 business day for it to be processed. 🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Hi @dlakatos847 and thank you for this contribution! Please let me know if you have any questions regarding submitting a CLA form. Thank you! |
Hi @mphilbrick211, |
@dlakatos847 - I've reached out to our legal side as well to see if I can get you some guidance. Stay tuned! |
|
@dlakatos847 per our legal team, first we need to confirm the following:
Regarding the question on committing resources, that doesn't apply here. I think you may be referring to our "core contributor" program, which is separate from being a general contributor. Core contributors are individuals who commit a certain number of hours per month to maintaining / improving the platform... whereas an entity / master service agreement with your company would simply allow you to contribute on behalf of the company as needed. You can also add additional coworkers to the entity agreement as needed by reaching out to our support team. There are no minimum time requirements with the entity agreement. Please let me know if this helps clear things up, and which type of agreement you'd like to proceed with. Thanks! |
|
@mphilbrick211 Thank you very much for the clarification. As my colleague @rblst and I are intending to contribute to the @openedx project on behalf of our company @sysagnostic, signing an entity CLA seems to be the appropriate choice. I recommend to continue the discussion about the signing process and details of the agreement in a private channel of your choice:
Looking forward hearing from you. |
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: abdullahwaheed <42172960+abdullahwaheed@users.noreply.github.com>
Description
Open edX Hungarian translation is at 100% yet the language could not be selected in the Account MFE. Fixes #1391.
How Has This Been Tested?
Screenshots/sandbox:
Include a link to the sandbox for design changes or screenshot for before and after. Remove this section if it's not applicable.