-
Notifications
You must be signed in to change notification settings - Fork 178
fix: remove 2u specific links #1377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1377 +/- ##
==========================================
- Coverage 68.25% 68.13% -0.12%
==========================================
Files 120 120
Lines 2372 2376 +4
Branches 656 657 +1
==========================================
Hits 1619 1619
- Misses 707 711 +4
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@MaxFrank13 - do operators have to supply their own links, or could we have some default links that point at docs.openedx.org? |
We certainly could! But I'm not sure those links exist in docs.openedx.org. For example, the email confirmation link is supposed to lead to a user facing page. I don't believe such a page exists in docs.openedx.org. I could be wrong though! My understanding is that docs.openedx.org is more for operators than it is for users. And all of these links are for users (ie. email confirmation, account basics, learner support, etc.) so I think requiring operators to provide the links via configuration makes the most sense. |
|
We have a learner's guide, and can always create new pages. I think it's better to have some default, rather than broken links, unless the broken links are hidden from the UI if they aren't defined.https://docs.openedx.org/en/latest/learners/index.html ETA: We also have an Educator's guide, which is comprehensive. This is often useful for Studio or Inst Dash links. https://docs.openedx.org/en/latest/educators/index.html |
The learner's guide is great. And I agree having defaults would be good. It looks like:
Making them hidden is certainly an option but then we are changing the behavior which feels like it might be out of scope when the main goal here was to eliminate some org specific code. That may also require input from other stakeholders? What are your thoughts? |
|
Sorry for the late reply. I agree with your proposed defaults. Thanks! |
This updates hardcoded links to instead use their corresponding configuration values. The hardcoded values were only relevant for 2u/edX