bugfix: Fix Mongo contents queries when content_type is unset #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taimoor-ahmed-1
approved these changes
Dec 5, 2025
rehmansheikh222
force-pushed
the
fix-mongo-unread-comment-count
branch
from
f54a4f1 to
8153396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the MongoDB discussions backend where unread_comment_count was always 0 because BaseContents.override_query was injecting _type: "" when content_type was unset. The method now only adds the _type filter if content_type is defined, allowing read state queries to correctly count comment documents.
Fixes #264.