Skip to content

Conversation

@taimoor-ahmed-1
Copy link
Contributor

This PR fixes the issue when migrating threads/comments from mongodb to mysql timestamps were not being migrated correctly.

@taimoor-ahmed-1 taimoor-ahmed-1 self-assigned this Nov 28, 2025
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 28, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @taimoor-ahmed-1!

This repository is currently maintained by @openedx/wg-maintainers-forums.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

This PR fixes the issue when migrating threads/comments from mongodb to mysql timestamps were not being migrated correctly.
@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the fix/thread_comment_timestamp_in_migration branch from be03ac5 to c3440b2 Compare December 1, 2025 06:52
Copy link

@asadali145 asadali145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested timestamps locally and looks good

@taimoor-ahmed-1 taimoor-ahmed-1 merged commit 776fc4d into master Dec 1, 2025
14 checks passed
@taimoor-ahmed-1 taimoor-ahmed-1 deleted the fix/thread_comment_timestamp_in_migration branch December 1, 2025 12:18
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Dec 1, 2025
@blarghmatey
Copy link
Contributor

Thanks for the fix! Any chance we can get this into a release and have the package bumped in edx-platform? It would also be helpful to get that change backported to Ulmo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants