-
Notifications
You must be signed in to change notification settings - Fork 17
feat: Optimize MySQL backend APIs to improve performance #246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @taimoor-ahmed-1! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
@ormsbee this is the initial work to optimize the mysql backend in forum. I am working on providing improvement stats as POC for this work. |
676f78f to
e4c88a9
Compare
b8b1b8b to
d5b1f01
Compare
947db3e to
e6a07b4
Compare
This commit introduces query optimizations to reduce database queries and improve response times: - Fixed N+1 queries in threads_presentor, get_paginated_user_stats, and other methods using select_related/prefetch_related - Optimized get_read_states to prefetch data in bulk instead of individual queries - Optimized get_abuse_flagged_count and get_endorsed with bulk aggregations - Removed duplicate annotations in handle_threads_query - Added query optimizations across prepare_thread, validate_thread_and_user, and other methods Performance impact: Reduced queries from O(n) to O(1)/O(k), eliminated N+1 patterns, improved bulk operations. All changes maintain backward compatibility.
e6a07b4 to
e6aae67
Compare
This commit introduces query optimizations to reduce database queries and improve response times:
Performance impact: Reduced queries from O(n) to O(1)/O(k), eliminated N+1 patterns, improved bulk operations. All changes maintain backward compatibility.