Skip to content

Conversation

@taimoor-ahmed-1
Copy link
Contributor

The Mongo→MySQL migration could crash when a MongoContent mapping was missing, e.g.: forum.backends.mysql.models.MongoContent.DoesNotExist at create_or_update_comment

This change makes the migration resilient by logging the relevant IDs and continuing.

create_or_update_comment: catch missing thread/parent mappings and missing target objects; log and return create_or_update_edit_history: guard missing mapping/target objects; log and return
create_or_update_abuse_flaggers: guard missing mapping/target objects; log and return
migrate_subscriptions: guard missing mapping/target objects; log and continue

@taimoor-ahmed-1 taimoor-ahmed-1 self-assigned this Aug 12, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @taimoor-ahmed-1!

This repository is currently maintained by @openedx/wg-maintainers-forums.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 12, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 12, 2025
@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the fix/log_failures_in_mongo_2_mysql_command branch 2 times, most recently from 899728c to ba01ff6 Compare August 12, 2025 06:45
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Aug 14, 2025
@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the fix/log_failures_in_mongo_2_mysql_command branch from 7b02b17 to 8d0b717 Compare August 18, 2025 18:50
The Mongo→MySQL migration could crash when a MongoContent mapping was missing, e.g.:
forum.backends.mysql.models.MongoContent.DoesNotExist at create_or_update_comment

This change makes the migration resilient by logging the relevant IDs and continuing.

create_or_update_comment: catch missing thread/parent mappings and missing target objects; log and return
create_or_update_edit_history: guard missing mapping/target objects; log and return
create_or_update_abuse_flaggers: guard missing mapping/target objects; log and return
migrate_subscriptions: guard missing mapping/target objects; log and continue

close: #211
@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the fix/log_failures_in_mongo_2_mysql_command branch from 8d0b717 to 714fe81 Compare August 18, 2025 18:52
Copy link
Contributor

@Faraz32123 Faraz32123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taimoor-ahmed-1 taimoor-ahmed-1 merged commit 51ec507 into master Aug 19, 2025
14 checks passed
@taimoor-ahmed-1 taimoor-ahmed-1 deleted the fix/log_failures_in_mongo_2_mysql_command branch August 19, 2025 10:20
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants