-
Notifications
You must be signed in to change notification settings - Fork 17
fix: Log missing content mapping in mongo2mysql cmd #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Log missing content mapping in mongo2mysql cmd #220
Conversation
|
Thanks for the pull request, @taimoor-ahmed-1! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
899728c to
ba01ff6
Compare
7b02b17 to
8d0b717
Compare
The Mongo→MySQL migration could crash when a MongoContent mapping was missing, e.g.: forum.backends.mysql.models.MongoContent.DoesNotExist at create_or_update_comment This change makes the migration resilient by logging the relevant IDs and continuing. create_or_update_comment: catch missing thread/parent mappings and missing target objects; log and return create_or_update_edit_history: guard missing mapping/target objects; log and return create_or_update_abuse_flaggers: guard missing mapping/target objects; log and return migrate_subscriptions: guard missing mapping/target objects; log and continue close: #211
8d0b717 to
714fe81
Compare
Faraz32123
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The Mongo→MySQL migration could crash when a MongoContent mapping was missing, e.g.: forum.backends.mysql.models.MongoContent.DoesNotExist at create_or_update_comment
This change makes the migration resilient by logging the relevant IDs and continuing.
create_or_update_comment: catch missing thread/parent mappings and missing target objects; log and return create_or_update_edit_history: guard missing mapping/target objects; log and return
create_or_update_abuse_flaggers: guard missing mapping/target objects; log and return
migrate_subscriptions: guard missing mapping/target objects; log and continue