Skip to content

Conversation

@Ali-Salman29
Copy link
Contributor

The PR refactors the get_user_subscriptions function to use positional and optional arguments instead of a general query_params dictionary. This refactoring makes this function work similarly to other functions, such as get_user_threads.

@openedx-webhooks
Copy link

Thanks for the pull request, @Ali-Salman29!

This repository is currently maintained by @openedx/wg-maintainers-forums.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@taimoor-ahmed-1 taimoor-ahmed-1 force-pushed the fix/refactor-unpack-query-params-user-subscription branch from 32411c6 to d51e782 Compare September 15, 2025 06:51
@taimoor-ahmed-1 taimoor-ahmed-1 merged commit 3aa5d36 into master Sep 15, 2025
14 checks passed
@taimoor-ahmed-1 taimoor-ahmed-1 deleted the fix/refactor-unpack-query-params-user-subscription branch September 15, 2025 06:55
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants