Skip to content

feat: meilisearch support #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
regisb merged 4 commits into from
Nov 12, 2024
Merged

feat: meilisearch support #126

regisb merged 4 commits into from
Nov 12, 2024

Conversation

@regisb
Copy link
Contributor

@regisb regisb commented Nov 8, 2024 •
edited
Loading

Add a search backend with Meilisearch support. Some very minor features are not supported, but it's otherwise fully functional.

@regisb
chore: refactor search backend for easier extensibility
cc925fa 
The following changes make it easier to later add a search backend based
on Meilisearch:

- Implement base abstract search backend
- Move Elasticsearch search backend to dedicated file
- Make sure that ThreadSearch keeps working as expected.
- Remove all references to elasticsearch outside of the es module, such as "es_helper", etc.
- Remove references to `FORUM_ENABLE_ELASTIC_SEARCH`
- Implement search backend setting: `FORUM_SEARCH_BACKEND`
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 8, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 8, 2024

Thanks for the pull request, @regisb!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently unmaintained.

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:

  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@regisb regisb force-pushed the regisb/meilisearch branch 2 times, most recently from 42b8a1a to dbb6603 Compare November 11, 2024 10:54
@regisb regisb force-pushed the regisb/meilisearch branch 5 times, most recently from dc69b58 to e7b708c Compare November 11, 2024 15:16
@regisb
feat: meilisearch search backend
e4df88c 
We use the search backend abstraction from previous commit to implement
a Meilisearch backend. This backend has the following limitations:

- No query suggestion: this feature is unsupported by Meilisearch.
- No weights for title/body search: but anyway, scoring was mostly
  ignored by the previous implementation, so this is not a big loss.
@regisb regisb force-pushed the regisb/meilisearch branch from e7b708c to e4df88c Compare November 11, 2024 15:16
@salman299
Copy link

salman299 commented Nov 12, 2024

LGTM!

@regisb regisb merged commit 46eb344 into openedx:master Nov 12, 2024
@regisb regisb deleted the regisb/meilisearch branch November 12, 2024 16:54
@regisb regisb mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ali-Salman29 Ali-Salman29 Ali-Salman29 approved these changes

+1 more reviewer

@salman299 salman299 salman299 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@regisb @openedx-webhooks @salman299 @Ali-Salman29