Skip to content

Conversation

@pomegranited
Copy link
Contributor

Description

Addresses libraries API TODOs introduced by #36371.

Private ref: FAL-4052

No end users are affected by this change.

Supporting information

Part of: openedx/frontend-app-authoring#1703

Testing instructions

Should be enough to do a code review and careful check of the tests to ensure they validate the desired behaviour for these new methods.

Deadline

ASAP -- want to get in before Teak cut

@openedx-webhooks
Copy link

openedx-webhooks commented Apr 3, 2025

Thanks for the pull request, @pomegranited!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 3, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 3, 2025
@pomegranited pomegranited changed the title Jill/libraries api refactor Finishes refactoring libraries APIs [FC-0083] Apr 3, 2025
@pomegranited pomegranited marked this pull request as draft April 3, 2025 10:07
@pomegranited pomegranited marked this pull request as ready for review April 3, 2025 10:27
@pomegranited pomegranited requested a review from rpenido April 3, 2025 10:31
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @pomegranited!

  • I tested this by checking the API tests and navigating through the UI, checking if everything is still working fine
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I will merge it on Monday morning

@ChrisChV ChrisChV enabled auto-merge (squash) April 7, 2025 13:57
@ChrisChV ChrisChV merged commit 94468ef into openedx:master Apr 7, 2025
48 checks passed
@ChrisChV ChrisChV deleted the jill/libraries-api-refactor branch April 7, 2025 14:17
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Apr 7, 2025
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

irtazaakram pushed a commit that referenced this pull request Apr 10, 2025
Addresses libraries API TODOs introduced by #36371
tonybusa pushed a commit to tonybusa/edx-platform that referenced this pull request Apr 23, 2025
UsamaSadiq pushed a commit that referenced this pull request May 14, 2025
Addresses libraries API TODOs introduced by #36371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants