Skip to content

Conversation

@ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Mar 13, 2025

Description

  • Refactored the code to use LibraryElementKey instead of LibraryCollectionKey
  • New units module created in content_libraries.
  • get_library_unit_usage_key func created.
  • Which edX user roles will this change impact? "Developer"

Supporting information

Testing instructions

  • Check all the code.
  • Verify that the test covers the changes.

Deadline

None

Other information

  • Bump opaque-keys version before merge this PR.

@openedx-webhooks
Copy link

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 13, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 13, 2025
@ChrisChV ChrisChV changed the title feat: get_library_unit_usage_key in new content_libraries.units module feat: get_library_unit_usage_key in new content_libraries.units module [FC-0083] Mar 13, 2025
@bradenmacdonald
Copy link
Contributor

I have included most of these changes in #36371 so I don't think we need this PR. Thanks!

@ChrisChV ChrisChV closed this Mar 14, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants