-
Notifications
You must be signed in to change notification settings - Fork 10
feat!: django 5.2 support #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2c3ecd2 to
3d2e273
Compare
7b504d6 to
bbc8d2c
Compare
UsamaSadiq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've tested the migration effect on sandbox and everything looks good. We can merge this PR but bumping the package in edx-platform will need to wait till SRE team has confirmed the migration change effect on db.
|
@UsamaSadiq is that work schedule by the SRE team at 2U? I don't want wait for too long for that to be completed. |
| new_name='idx_failedtask_task_exc', | ||
| old_fields=('task_name', 'exc'), | ||
| ), | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ALTER INDEX "celery_utils_failedtask_task_name_exc_efb8c9be_idx" RENAME TO "idx_failedtask_task_exc";
@awais786 here is the query it is generating for postgresql.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is also a low cost metadata only query so it should be safe to run on even large tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed!
|
@awais786 can you update the tox and github workflows to also run tests on django 5.2? |
Yes, I've verified this change on sandbox and have created an issue for the SRE team to verify on large tables. We should be hearing back from them by the day end tomorrow and then we can proceed with merging this PR along with others. |
|
Tested the potential effect of the
FYI @feanil |
issue #338
Django
5.2support.index_togethersyntax.Raw sql generated by 0003 migration
python manage.py sqlmigrate celery_utils 0003On sqlite
mysql8 devstack
NOTE:
we need to find a way how to deploy this on prod, also each instance will have different index name.
PROD count. (performance impact will be decided as per records, Arbi bom will provide this)
Testing instruction:
Set up a sandbox environment using the current master branch and populate it with sample data.
Then, upgrade to the new version of edx-celeryutils and run the migration to:
This will help validate the change before delpoying it to staging or production.