Skip to content

Conversation

@MoisesGSalas
Copy link
Contributor

@MoisesGSalas MoisesGSalas commented Apr 8, 2025

The only usage of Django is in ConfigureCodeJailMiddleware. A small test
to check that the middleware can be correctly instantiated is included.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 8, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 8, 2025

Thanks for the pull request, @MoisesGSalas!

This repository is currently maintained by @moisesgsalas.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 8, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 14, 2025
@feanil
Copy link
Contributor

feanil commented May 6, 2025

@MoisesGSalas what's the current state of this work, do you think you'll be abel to get something reading for review this week so we can land the update before the deadline next week?

@feanil feanil linked an issue May 6, 2025 that may be closed by this pull request
4 tasks
@MoisesGSalas
Copy link
Contributor Author

Hi @feanil, I will be retaking this tomorrow and hope to have it ready by the end of the week.

@MoisesGSalas MoisesGSalas force-pushed the mgs/django52 branch 3 times, most recently from 95f66b7 to 4845a25 Compare May 8, 2025 21:09
@MoisesGSalas MoisesGSalas marked this pull request as ready for review May 8, 2025 21:16
@MoisesGSalas MoisesGSalas requested a review from feanil May 8, 2025 21:16
@MoisesGSalas MoisesGSalas force-pushed the mgs/django52 branch 3 times, most recently from dbeda46 to 54b6589 Compare May 8, 2025 21:26
The only usage of Django is in ConfigureCodeJailMiddleware. A small test
to check that the middleware can be correctly instantiated is included.
@MoisesGSalas
Copy link
Contributor Author

Hi @feanil, This one should be ready for review.

@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions May 12, 2025
@MoisesGSalas MoisesGSalas merged commit 276c76d into master May 13, 2025
7 checks passed
@MoisesGSalas MoisesGSalas deleted the mgs/django52 branch May 13, 2025 20:37
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add Django 5.2 support to codejail

4 participants