adding helper function to set blobstore io timeout#65
Open
abhilashshetty04 wants to merge 1 commit intov25.05.x-mayastorfrom
Open
adding helper function to set blobstore io timeout#65abhilashshetty04 wants to merge 1 commit intov25.05.x-mayastorfrom
abhilashshetty04 wants to merge 1 commit intov25.05.x-mayastorfrom
Conversation
abhilashshetty04
requested review from
Abhinandan-Purkait and
tiagolobocastro
abhilashshetty04
force-pushed
the
bs_bdev_timeout
branch
from
91eb2f9 to
ed1e543
Compare
Signed-off-by: Abhilash Shetty <abhilash.shetty@datacore.com>
abhilashshetty04
force-pushed
the
bs_bdev_timeout
branch
from
ed1e543 to
f7ebcae
Compare
| { | ||
| struct blob_bdev *blob_bdev = (struct blob_bdev *)bs_dev; | ||
|
|
||
| return spdk_bdev_set_timeout(blob_bdev->desc, timeout_in_sec, cb_fn, cb_arg); |
Member
There was a problem hiding this comment.
Can we not do this from mayastor?
Member
Author
There was a problem hiding this comment.
struct blob_bdev is defined inside blob_bdev.c . It doesn't get generated in libspdk-rs targets as well.
Member
Author
There was a problem hiding this comment.
bs_dev desc is stored inside blob_bdev during blob_dev_init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.