Merged
Conversation
kstigen
requested changes
Jun 24, 2025
Contributor
kstigen
left a comment
kstigen
left a comment
There was a problem hiding this comment.
A bit much to go into detail, but take a look at the tests.
| mockResponse.setProperties(mockForecast); | ||
|
|
||
| when(api.getSunriseAndSunset(lat, lon, null, null)).thenReturn(mockResponse); | ||
| METJSONSunrise response = api.getSunriseAndSunset(lat, lon, null, null); |
Contributor
There was a problem hiding this comment.
This test, doesn't really test anything. You are mocking the entire call to the api.getSunriseAndSunset, so we are basically testing that that setup of the mocking code works.
Contributor
Author
There was a problem hiding this comment.
I have now changed to mocking the server, and doing an integration test. I see that I have made the same mistake on the other api clients, but these should be changed in a different PR.
This makes it do a test of serialization and deserialization and so on.
kstigen
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the client to use MET api directly instead of the OpenEPI Weather api.