update Olivier Branch with Main #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add wind plotting functionality * Refactor GUI: Complete modular architecture with all GUI tabs extracted, export functionality, and utilities (#263) * Initial plan * Phase 1: Add constants, utility functions, and improve documentation Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Phase 2: Extract helper methods and reduce code duplication Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Phase 3: Add variable label/title constants and improve docstrings Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Final: Add comprehensive refactoring documentation and summary Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Add export functionality: PNG and MP4 animations for all visualizations Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Phase 4: Begin code organization - extract utils module and create gui package structure Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Add comprehensive additional improvements proposal document Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bugfixes related to import and animattion functionality * updated structure for further refactoring * Refactor: Extract DomainVisualizer and rename gui_app_backup.py to application.py Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bugfix * bugfix on loading domain * Refactor: Extract WindVisualizer to modular architecture Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Refactor: Extract Output2DVisualizer for 2D NetCDF visualization Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Refactor: Extract Output1DVisualizer - Complete modular architecture achieved! Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bugfixes loading files * removed netcdf check * bugfixes after refractoring * bugfixes with domain overview * Speeding up complex drawing * hold on functionality added * Tab to run code added. * Update aeolis/gui/application.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update aeolis/gui/application.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update aeolis/gui/visualizers/domain.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update aeolis/gui/visualizers/domain.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update aeolis/gui/main.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update aeolis/gui/visualizers/output_2d.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Rename visualizers folder to gui_tabs and update all imports Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bigfixes related to refactoring * reducing code lenght by omitting some redundancies * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> Co-authored-by: Sierd <sierd.devries@tudelft.nl> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
#268) * Refactor GUI: Complete modular architecture with all GUI tabs extracted, export functionality, and utilities (#263) * Initial plan * Phase 1: Add constants, utility functions, and improve documentation Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Phase 2: Extract helper methods and reduce code duplication Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Phase 3: Add variable label/title constants and improve docstrings Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Final: Add comprehensive refactoring documentation and summary Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Add export functionality: PNG and MP4 animations for all visualizations Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Phase 4: Begin code organization - extract utils module and create gui package structure Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Add comprehensive additional improvements proposal document Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bugfixes related to import and animattion functionality * updated structure for further refactoring * Refactor: Extract DomainVisualizer and rename gui_app_backup.py to application.py Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bugfix * bugfix on loading domain * Refactor: Extract WindVisualizer to modular architecture Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Refactor: Extract Output2DVisualizer for 2D NetCDF visualization Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * Refactor: Extract Output1DVisualizer - Complete modular architecture achieved! Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bugfixes loading files * removed netcdf check * bugfixes after refractoring * bugfixes with domain overview * Speeding up complex drawing * hold on functionality added * Tab to run code added. * Update aeolis/gui/application.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update aeolis/gui/application.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update aeolis/gui/visualizers/domain.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update aeolis/gui/visualizers/domain.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update aeolis/gui/main.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update aeolis/gui/visualizers/output_2d.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Rename visualizers folder to gui_tabs and update all imports Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> * bigfixes related to refactoring * reducing code lenght by omitting some redundancies * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> Co-authored-by: Sierd <sierd.devries@tudelft.nl> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Delete ADDITIONAL_IMPROVEMENTS.md * deleted md files --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Sierd <14054272+Sierd@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.