Bumping ed25519-dalek to v2 and fix broken v1 APIs. #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
ed25519-dalekdependency to version 2 and refactors the key generation logic to align with the new API. The changes primarily involve replacing the deprecatedKeypairstruct with the newSigningKeyandVerifyingKeytypes, ensuring compatibility with the updated library.Dependency Update:
ed25519-dalekdependency from version1.0.1to2inCargo.toml. This change ensures the project uses the latest version of the library, which introduces a new API for key generation.Key Generation Refactor:
generate_key_pairfunction insrc/keygen.rsto replace the deprecatedKeypair::generatemethod with explicit creation ofSecretKey,SigningKey, andVerifyingKey. This aligns with the newed25519-dalekAPI and ensures compatibility with version 2.generate_openssh_key_pairfunction insrc/keygen.rsto use the newSigningKeyandVerifyingKeytypes for generating OpenSSH-compatible key pairs. Adjusted the handling of raw key bytes and the encoding functions accordingly.