Open
Conversation
mccalluc
commented
Mar 6, 2026
Comment on lines
-263
to
-271
| is_just_histograms = all( | ||
| plan_column[0].statistic_name == histogram.name | ||
| for plan_column in self.analysis_plan.analysis_columns.values() | ||
| ) | ||
| margins_list = ( | ||
| # Histograms don't need margins. | ||
| "[]" | ||
| if is_just_histograms | ||
| else self._make_margins_list( |
Contributor
Author
There was a problem hiding this comment.
is_just_histograms wasn't a good check, because we actually do need the margins, albeit with public keys, if we want to be able to set delta to zero.
Contributor
Author
|
There are a few PRs out that change (improve?) the code generation. My plan is to get Mike to look at the generated code when they are merged, but before the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Shoeboxam , since this is about demonstrating correct API usage, could you look at this PR?