Draft
Conversation
MikeNeilson
force-pushed
the
feature/549-login-form-initial
branch
from
edc7ee0 to
ec610be
Compare
MikeNeilson
force-pushed
the
feature/549-login-form-initial
branch
from
ec610be to
344f435
Compare
|
adamkorynta
added a commit
that referenced
this pull request
Nov 25, 2025
added to the existing username/password login though it'll just get replaced by #574 once this is done, will update to allow setting the organizationid header need to add to the settings options a place where we can change the office id without having to logout also need to populate swagger with a default organization header
adamkorynta
added a commit
that referenced
this pull request
Dec 10, 2025
* parameterize orgainzation (office) id from the client to the REST API added to the existing username/password login though it'll just get replaced by #574 once this is done, will update to allow setting the organizationid header need to add to the settings options a place where we can change the office id without having to logout also need to populate swagger with a default organization header * allow the client to choose an organization id in the login prompt * add organization selector to allow clients to change organizations without having to logout * cleanup order of operations so that excessive invalid requests aren't made when user is not logged in * fix jstl references for jakarta update * remove loginTest as it isn't hooked into integration test system * add org header to swagger page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
Partial? opendcs/opendcs#1591.
Depends on #582, will get back to this after that.
Solution
1 (todo) use openapi security schemes to build login form
2 remove http basic
3 mimic (in swagger) username/password with oauth2 ropc flow
how you tested the change
Describe what was done to test the change. This section can be left blank
if automated tests demonstrating usage are provided in the PR.
Where the following done:
(Formerly called regression tests.)
If you aren't sure leave unchecked and we will help guide you to want needs changing where.