-
Notifications
You must be signed in to change notification settings - Fork 8
Use bazel5 RPM; add aarch64 to postgresql patch #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe updates extend conditional compilation in a PostgreSQL patch to exclude ARM 64-bit architectures from certain CPU feature detection logic. Separately, the Red Hat-based Dockerfile is modified to install Bazel via Fedora Copr and streamline package management, with minor formatting adjustments. No public APIs or exported declarations are changed. Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
@VaniHaripriya Would you be a good person to review this from your team? 🙂 @PankhudiJ17 I'd also appreciate a review from you, since I'm touching your recent patch, and updated the Dockerfile to use a bazel that can also build for ppc64le (and actually built an image for it). |
rareddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
This is a manual cherry-pick of the following PR in ODH: opendatahub-io#21
This is a manual cherry-pick of the changes from the following PR in ODH, to the Dockerfile.konflux: opendatahub-io#21
Description
The bazel5 RPMs used here from the galileo/bazel COPR repo are built
by grdryn for EL9 on EL9 builders in Fedora COPR
infrastructure. They're built for all 4 of our target architectures,
which means that we should be able to use it to build programs on all
of x86_64, aarch64, ppc64le, and s390x.
The patch that @PankhudiJ17 added to allow for ppc64le builds also
allows aarch64 builds when a similar change is made, so that's added
to the patch file here too.
How Has This Been Tested?
Merge criteria:
Summary by CodeRabbit
Bug Fixes
Chores