Skip to content

Conversation

@cibelius
Copy link
Contributor

@cibelius cibelius commented Jan 28, 2026

Description

Resolves #11677

See discussion: https://opencrvsworkspace.slack.com/archives/C09FTGEGE0L/p1769514672861949?thread_ts=1769512212.253079&cid=C09FTGEGE0L

Screenshot 2026-01-28 at 13 35 16

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@cibelius cibelius marked this pull request as ready for review January 28, 2026 11:32
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

ℹ️ Coverage metrics explained:
Statements — Executed code statements (basic logic lines)
Branches — Tested decision paths (if/else, switch, ternaries)
Functions — Functions invoked during tests
Lines — Source lines executed

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

📊 commons test coverage

Statements: 67.24%
Branches:   32.77%
Functions:  50.2%
Lines:      66.64%
Updated at: Thu, 29 Jan 2026 07:21:06 GMT

@cibelius cibelius changed the title Search results always show 'Review' as CTA Search results should always show 'Review' as CTA Jan 28, 2026
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

📊 events test coverage

Statements: 86.44%
Branches:   84.01%
Functions:  92.94%
Lines:      86.44%
Updated at: Thu, 29 Jan 2026 07:24:49 GMT

Copy link
Contributor

@Zangetsu101 Zangetsu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the 'DEFAULT' value does not work anymore? At least according to the recording in #11677. Should we fix that or perhaps remove it altogether?

@cibelius cibelius requested a review from Zangetsu101 January 28, 2026 12:16
@Zangetsu101
Copy link
Contributor

@cibelius What about this one?

It seems like the 'DEFAULT' value does not work anymore? At least according to the recording in #11677. Should we fix that or perhaps remove it altogether?

@cibelius
Copy link
Contributor Author

@Zangetsu101 Oh sorry didn't notice that comment! My bad.

Good point, the 'DEFAULT' CTA is not working quite correctly, and we don't need to support it. Removed it.

Copy link
Contributor

@Zangetsu101 Zangetsu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mention this in the CHANGELOG as a breaking change as countries are most likely using it. We should also let them know what should be used instead and why

@ocrvs-bot
Copy link
Contributor

Your environment is deployed to https://ocrvs-11677.e2e-k8s.opencrvs.dev

@cibelius cibelius merged commit cd4b7f1 into develop Jan 29, 2026
84 checks passed
@cibelius cibelius deleted the ocrvs-11677 branch January 29, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Primary action button does not work and is incorrectly derived from the first action menu item in search results workqueue.

4 participants