-
Notifications
You must be signed in to change notification settings - Fork 95
Search results should always show 'Review' as CTA #11690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
ℹ️ Coverage metrics explained: |
📊 commons test coverage |
📊 events test coverage |
Zangetsu101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the 'DEFAULT' value does not work anymore? At least according to the recording in #11677. Should we fix that or perhaps remove it altogether?
packages/client/src/v2-events/features/events/Search/QuickSearchIndex.tsx
Show resolved
Hide resolved
|
@Zangetsu101 Oh sorry didn't notice that comment! My bad. Good point, the 'DEFAULT' CTA is not working quite correctly, and we don't need to support it. Removed it. |
Zangetsu101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mention this in the CHANGELOG as a breaking change as countries are most likely using it. We should also let them know what should be used instead and why
|
Your environment is deployed to https://ocrvs-11677.e2e-k8s.opencrvs.dev |
Description
Resolves #11677
See discussion: https://opencrvsworkspace.slack.com/archives/C09FTGEGE0L/p1769514672861949?thread_ts=1769512212.253079&cid=C09FTGEGE0L
Checklist