Skip to content

Conversation

@makelicious
Copy link
Contributor

@makelicious makelicious commented Jan 27, 2026

Description

search endpoint expects scopes in v2 format.
Changes:

  • Deprecate code where old search was used
  • Update test cases and tokens
  • Fix issue where events created by system did not have createdAtLocation
  • Deprecate CreatedAtLocation type. Harmful since it hid the nullish.
  • Write test cases

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@github-actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@github-actions
Copy link

github-actions bot commented Jan 27, 2026

ℹ️ Coverage metrics explained:
Statements — Executed code statements (basic logic lines)
Branches — Tested decision paths (if/else, switch, ternaries)
Functions — Functions invoked during tests
Lines — Source lines executed

@github-actions
Copy link

github-actions bot commented Jan 27, 2026

📊 commons test coverage

Statements: 67.13%
Branches:   32.71%
Functions:  50%
Lines:      66.54%
Updated at: Thu, 29 Jan 2026 08:40:58 GMT

within the scope of the current work, not close enough to be relevant.
@makelicious makelicious force-pushed the chore/deprecate-v1-search-scop branch from e0e7b90 to af18ce3 Compare January 27, 2026 11:42
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

📊 events test coverage

Statements: 86.3%
Branches:   84.12%
Functions:  92.94%
Lines:      86.3%
Updated at: Thu, 29 Jan 2026 10:27:24 GMT

@makelicious makelicious changed the title [WIP] Chore/deprecate v1 search scop Deprecate V1 search scope Jan 29, 2026
@makelicious makelicious linked an issue Jan 29, 2026 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure jurisdiction for search scopes

3 participants