fix: add error handling and toast notification to Reinstate action #11624
+82
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hello OpenCRVS team I’ve opened a PR for the above issue Could someone please review the PR and approve the workflows when convenient? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an onError handler to the Mutation component in ReinstateButton.tsx. Previously, if the reinstate action failed, the user received no feedback. Now, a Toast notification appears with a "Retry" action to improve the user experience and error visibility.
Changes:
Added isErrorDismissed state to
ReinstateButton
.
Implemented onError callback in Apollo .
Rendered component with a retry mechanism.
Used localized error messages via intl