Skip to content

Conversation

@agarny
Copy link
Contributor

@agarny agarny commented Jan 20, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 20, 2026 01:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies layout handling by moving from JS-driven size tracking to flexbox/CSS-based sizing and cleans up unused utilities and props. It also updates a couple of dependencies and bumps the application version.

Changes:

  • Refactored SimulationExperimentView, ContentsComponent, OpenCOR, and IssuesView to rely on flexbox and percentage-based heights instead of manually tracking and propagating widths/heights.
  • Simplified IssuesView and SimulationExperimentView APIs by removing width/height props and associated resize logic, and deleted now-unused height-tracking helpers from vueCommon.ts.
  • Bumped package versions (version fields, @primeuix/themes, and tar) and updated both Bun lockfiles accordingly.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/renderer/src/components/views/SimulationExperimentView.vue Reworked layout to use a flex column root container, internal grow/min-h-0 areas, and removed width/height props and toolbar height tracking logic.
src/renderer/src/components/views/IssuesView.vue Simplified props (only margins + issues), converted sizing to CSS (.issues class and h-full usage), and removed JS-based resize logic and SHORT_DELAY usage.
src/renderer/src/components/OpenCOR.vue Simplified top-level layout to full-height flex, stopped computing and passing window/main-menu sizes, and updated IssuesView/ContentsComponent usage to rely on CSS sizing.
src/renderer/src/components/ContentsComponent.vue Removed width/height props and tablist height tracking, switched tabs/panels and nested views to flexbox with h-full/grow for consistent layout.
src/renderer/src/common/vueCommon.ts Removed unused CSS variable height-tracking helpers, leaving only active instance and theme-related utilities.
src/renderer/package.json Bumped renderer package version and updated @primeuix/themes dependency.
src/renderer/bun.lock Synchronized lockfile with the new @primeuix/themes version.
package.json Bumped root package version and updated @primeuix/themes and tar versions.
bun.lock Updated lockfile entries for @primeuix/themes and tar to match package.json.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@agarny agarny merged commit 492e7f3 into opencor:main Jan 20, 2026
14 checks passed
@agarny agarny deleted the cleaning-up branch January 20, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant