Post overlay addition and dmz removal nits#4490
Merged
lifubang merged 3 commits intoopencontainers:mainfrom Oct 30, 2024
Merged
Post overlay addition and dmz removal nits#4490lifubang merged 3 commits intoopencontainers:mainfrom
lifubang merged 3 commits intoopencontainers:mainfrom
Conversation
While this is used by the majority of upper container runtimes, it was not needed for runc itself. Since commit 515f09f runc uses overlay, too, so let's add a check for this. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
There is a typo in the comment (ClonedBinary should be CloneBinary), and the code has changed a bit since then, and it makes more sense to refer to CloneSelfExe now. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was added by commit f2f1621 when runc-dmz was still a thing. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
lifubang
added
the
backport/1.2-todo
lifubang
approved these changes
Oct 30, 2024
Contributor
Author
|
1.2 backport: #4494 |
lifubang
added
backport/1.2-done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny nits needed after merging #4482 and #4448. Easy to review.