Fix: Remove millisecond-to-microsecond conversion in response times #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary multiplication by 1000 and parseInt conversion in request-handler middleware. The response-time library already provides time in milliseconds, so no conversion is needed. This fixes inflated response time values and preserves sub-millisecond precision for accurate performance monitoring. Fixes opencomponents#1454
Collaborator
|
makes sense, thanks! |
ricardo-devis-agullo
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes inflated response times by removing unnecessary multiplication by 1000 in
src/registry/middleware/request-handler.ts.Problem
The
response-timelibrary already provides time in milliseconds (as documented here). The code was converting these milliseconds to microseconds by multiplying by 1000 and then parsing as an integer, which:parseInt)Solution
Changed:
to
This preserves the original millisecond precision and provides accurate response time reporting.
Screenshots
Testing
Related Issues
Fixes #1454