Adjust false positives from server errors #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a catch block for HttpException in MetricMiddleware to treat them as valid HTTP responses, updating request_status label accordingly before ending the timer. This prevents HttpExceptions from being counted as internal errors.
wilcorrea
approved these changes
Aug 28, 2025
…sitives-from-server-errors
Deleted GitHub Actions workflows for closing pull requests and handling releases. These workflows are no longer needed or have been moved.
wilcorrea
approved these changes
Aug 28, 2025
MateusSilveira98
approved these changes
Aug 28, 2025
luizmanhani
approved these changes
Aug 28, 2025
vs0uz4
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds improved handling for HTTP exceptions in the
MetricMiddleware, ensuring that metrics accurately reflect valid HTTP responses rather than internal errors.Metrics and error handling improvements:
HttpExceptionin theprocessmethod ofMetricMiddleware, so that HTTP exceptions are treated as valid responses and their status codes are recorded in metrics.HttpExceptionto support the new error handling logic inMetricMiddleware.php.