Skip to content

WIP: Assert if we fail to find a space #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheOneRing wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WIP: Assert if we fail to find a space #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/gui/folder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,10 +353,9 @@ bool Folder::isSyncRunning() const
QUrl Folder::webDavUrl() const
{
const QString spaceId = _definition.spaceId();
if (!spaceId.isEmpty()) {
if (auto *space = _accountState->account()->spacesManager()->space(spaceId)) {
return QUrl(space->drive().getRoot().getWebDavUrl());
}
Q_ASSERT(!spaceId.isEmpty());
if (auto *space = _accountState->account()->spacesManager()->space(spaceId); OC_ENSURE(space)) {
return QUrl(space->drive().getRoot().getWebDavUrl());
}
return _definition.webDavUrl();
}
Expand Down
1 change: 0 additions & 1 deletion src/gui/folder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ class OPENCLOUD_GUI_EXPORT FolderDefinition
private:
FolderDefinition(const QByteArray &id, const QUrl &davUrl, const QString &spaceId, const QString &displayName);

// oc10 and as cache for ocis
QUrl _webDavUrl;

QString _spaceId;
Expand Down