Correct the datetimes passed into the sin/cos encoder #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-e-h-p
approved these changes
Jan 6, 2026
| # Add datetime features | ||
| generation_config = self.config.input_data.generation | ||
| datetimes = pd.date_range( | ||
| t0 + minutes(generation_config.time_resolution_minutes), |
Contributor
There was a problem hiding this comment.
Just to check - this was determining length of what's generated right?
Member
Author
There was a problem hiding this comment.
Yeh that's right. The mistake was that I started it from the first step of the forecast but the old behaviour which we need to match is that it starts from the first step of the generation history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes a bug was introduced in #385 where the datetimes passed into the original sin/cos datetime encoder were unintentionally changed.
Also adds to tests so that the error in that original PR would have been caught
Checklist: