Skip to content

Renaming Nulls to NANs #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ram-from-tvl wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Renaming Nulls to NANs #287

ram-from-tvl wants to merge 3 commits into from

Conversation

@ram-from-tvl
Copy link

@ram-from-tvl ram-from-tvl commented Sep 2, 2025

Fixes #285

@ram-from-tvl
Copy link
Author

ram-from-tvl commented Sep 2, 2025

Hi @peterdudfield
Please review it and let me know if any changes are required.
Thank you!

peterdudfield
peterdudfield reviewed Sep 2, 2025
View reviewed changes
src/nwp_consumer/internal/entities/tensorstore.py
mean = store_da.mean().values.mean()

return Success(
ParameterScanResult(
Copy link
Contributor

@peterdudfield peterdudfield Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you changed the object ParameterScanResult anywhere? I suspect you will need to if you want this change.

Aslo have you run pytest to check these changes?

Copy link
Author

@ram-from-tvl ram-from-tvl Sep 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @peterdudfield , I updated the ParameterScanResult object completely.

  • Field renamed: has_nulls: bool → has_nans: bool with updated documentation
  • scan.has_nulls → scan.has_nans and has_nulls=False → has_nans=False
  • Tests pass: All 4 tests in test_tensorstore.py run successfully.

Please let me know if any changes are required..?
Thank you!

Copy link
Contributor

@peterdudfield peterdudfield Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that

peterdudfield
peterdudfield approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I just need to find a way to make sure CI runs for external collobrators. Then we can merge

@ram-from-tvl
Copy link
Author

ram-from-tvl commented Sep 3, 2025

Sure @peterdudfield

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterdudfield peterdudfield peterdudfield approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename, nulls to nans

2 participants

@ram-from-tvl @peterdudfield