Conversation
ensure change_to_dataframe is assigned even if query_params is empty
Contributor
|
Do all other tests pass? Sorry I havent set the CI to work on external PR yet Update, got the CI running now |
previous addition wasn't sufficient. the param needs to be passed down the chain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fixes #64
Move the assignment outside the
ifstatement to ensurechange_to_dataframeis assigned even ifquery_paramsis empty.Passing an empty list into the method
self.format_to_dataframe(query_params)is fine.How Has This Been Tested?
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Doesn't affect data processing
Checklist: