Skip to content

Conversation

@bpk9
Copy link

@bpk9 bpk9 commented Feb 1, 2026

Problem

The skill sorting was being handled on the frontend, which means users needed to scroll down to load all skills before the list was properly sorted

Related Issues

#85

Screenshots

Description Screenshot
Prod
Before
After

@vercel
Copy link
Contributor

vercel bot commented Feb 1, 2026

@bpk9 is attempting to deploy a commit to the Amantus Machina Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link

greptile-apps bot commented Feb 1, 2026

Additional Comments (1)

src/routes/skills/index.tsx
[P2] Default sort/dir between UI and API are inconsistent, which can make initial loads surprising and make tests brittle.

SkillsIndex defaults to sort='newest' (line 65) and parseDir defaults to 'desc' except for name (line 24). But the Convex listPublicPageV2 defaults to sort='updated' (convex/skills.ts:736) and dir='desc'. If a client omits sort/dir (or older clients call this endpoint directly), the backend behavior won’t match the UI’s assumed defaults. Consider aligning defaults (either make the frontend explicitly set the canonical defaults for every request, or have the backend defaults match the UI’s defaults).

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/routes/skills/index.tsx
Line: 11:25

Comment:
[P2] Default sort/dir between UI and API are inconsistent, which can make initial loads surprising and make tests brittle.

`SkillsIndex` defaults to `sort='newest'` (line 65) and `parseDir` defaults to `'desc'` except for `name` (line 24). But the Convex `listPublicPageV2` defaults to `sort='updated'` (convex/skills.ts:736) and `dir='desc'`. If a client omits sort/dir (or older clients call this endpoint directly), the backend behavior won’t match the UI’s assumed defaults. Consider aligning defaults (either make the frontend explicitly set the canonical defaults for every request, or have the backend defaults match the UI’s defaults).

How can I resolve this? If you propose a fix, please make it concise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant