-
-
Notifications
You must be signed in to change notification settings - Fork 269
Fix initial skill sorting #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@bpk9 is attempting to deploy a commit to the Amantus Machina Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: src/routes/skills/index.tsx
Line: 11:25
Comment:
[P2] Default sort/dir between UI and API are inconsistent, which can make initial loads surprising and make tests brittle.
`SkillsIndex` defaults to `sort='newest'` (line 65) and `parseDir` defaults to `'desc'` except for `name` (line 24). But the Convex `listPublicPageV2` defaults to `sort='updated'` (convex/skills.ts:736) and `dir='desc'`. If a client omits sort/dir (or older clients call this endpoint directly), the backend behavior won’t match the UI’s assumed defaults. Consider aligning defaults (either make the frontend explicitly set the canonical defaults for every request, or have the backend defaults match the UI’s defaults).
How can I resolve this? If you propose a fix, please make it concise. |
Problem
The skill sorting was being handled on the frontend, which means users needed to scroll down to load all skills before the list was properly sorted
Related Issues
#85
Screenshots