Skip to content

fix: prevent infinite loading loop on skills page #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xcqtnr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent infinite loading loop on skills page #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/routes/skills/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,8 @@ export function SkillsIndex() {
}, [canLoadMore, hasQuery, isLoadingMore, loadMorePaginated])

useEffect(() => {
if (!canLoadMore || typeof IntersectionObserver === 'undefined') return
// Don't set up observer while loading to prevent infinite request loop
if (!canLoadMore || isLoadingMore || typeof IntersectionObserver === 'undefined') return
const target = loadMoreRef.current
if (!target) return
const observer = new IntersectionObserver(
Expand All @@ -218,7 +219,7 @@ export function SkillsIndex() {
)
observer.observe(target)
return () => observer.disconnect()
}, [canLoadMore, loadMore])
}, [canLoadMore, isLoadingMore, loadMore])

return (
<main className="section">
Expand Down