fix: django.contrib.postgres.fields.JSONField causes an error in Django 4.2 (fields.E904) https://docs.djangoproject.com/en/4.2/ref/checks/ #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgregg
approved these changes
Nov 11, 2024
fgregg
requested changes
Nov 11, 2024
Contributor
fgregg
left a comment
fgregg
left a comment
There was a problem hiding this comment.
@jpmckinney would you mind fixing the tests?
For example: env \ GEOS_LIBRARY_PATH='/opt/homebrew/opt/geos/lib/libgeos_c.dylib' \ GDAL_LIBRARY_PATH='/opt/homebrew/opt/gdal/lib/libgdal.dylib' \ DATABASE_DB=opencivicdata_test \ DATABASE_USER=myuser \ DATABASE_PASSWORD= \ PYTHONPATH=. pytest --ds=opencivicdata.tests.test_settings
Member
Author
|
@fgregg All green now. |
Contributor
|
thanks for this, @jpmckinney. hope all is well with you |
Member
Author
|
All good here :) It looks like the commit to roll the version to 3.3.1 is not on master. It was also tagged a "v3.3.1" (like v3.3.0). However, the other tags omit the "v". Okay for me to tag and release as "3.4.0" ? |
Contributor
|
go for it! |
Member
Author
|
Ah, I see why the "v" was included - the workflow only runs on "v*" tags. I'll use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.