Skip to content

Conversation

@baugetfa
Copy link
Collaborator

@baugetfa baugetfa commented Jul 31, 2025

I proposed to add wrapper functions for the cut and flow analysis (they are the ones I used for the publications)

  • added 2 wrapper functions for the cut and flow analysis in solver_wrapper.py
    • one for cut and flow with the pure hydraulic solver
    • a second for the solute and water solver
  • added also two python script examples for each case (I am preparing a jupyter nb)

Remark: working on it I realize that the code in wrapper is pretty hugly and can be optimized.

  • there are also some minor typo correction in math in docstrings

@baugetfa baugetfa self-assigned this Jul 31, 2025
@baugetfa baugetfa added the enhancement New feature or request label Jul 31, 2025
@baugetfa baugetfa requested a review from pradal July 31, 2025 15:58
Copy link
Contributor

@pradal pradal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite big and I need to discuss to understand the change.
So merge it if it is needed but difficult to me to have an opinion

@baugetfa
Copy link
Collaborator Author

baugetfa commented Sep 5, 2025

I won't merge it without discussion with you. I keep the PR open.

@pradal
Copy link
Contributor

pradal commented Sep 5, 2025

Excellent!

@baugetfa baugetfa merged commit 18888fd into main Oct 7, 2025
6 checks passed
@baugetfa baugetfa deleted the solver_wrapper branch November 20, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants