fix(elixir): fix malformed JSON event form codex message#50
Open
kevinw-openai wants to merge 2 commits intoopenai:mainfrom
Open
fix(elixir): fix malformed JSON event form codex message#50kevinw-openai wants to merge 2 commits intoopenai:mainfrom
kevinw-openai wants to merge 2 commits intoopenai:mainfrom
Conversation
Summary:
- only emit malformed Codex events for JSON-like protocol frames that
fail to decode
- keep logging non-JSON stream output without surfacing it to the
orchestrator dashboard
- add regression coverage for stderr noise and malformed protocol
frames
Rationale:
- Codex can write diagnostics to stderr during healthy turns, and the
merged stdio stream was incorrectly surfacing those lines as
malformed JSON events in the Symphony UI
- keeping malformed detection for JSON-looking frames preserves signal
for actual protocol corruption while removing false positives
Tests:
- mise exec -- mix format lib/symphony_elixir/codex/app_server.ex
test/symphony_elixir/app_server_test.exs
- MIX_ENV=test mise exec -- mix run --no-start -e
'Application.put_env(:symphony_elixir, :workflow_file_path,
System.fetch_env!("SYMPHONY_TEST_WORKFLOW")); Mix.Task.run("test",
["test/symphony_elixir/app_server_test.exs"])'
Co-authored-by: Codex <noreply@openai.com>
Resolved the only content conflict in
`elixir/test/symphony_elixir/app_server_test.exs` by keeping both the new
malformed-stream regression coverage and main's SSH app-server coverage.
Validation:
- MIX_ENV=test mise exec -- mix run --no-start -e 'Application.put_env(:symphony_elixir, :workflow_file_path, System.fetch_env!("SYMPHONY_TEST_WORKFLOW")); Mix.Task.run("test", ["test/symphony_elixir/app_server_test.exs"])'
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Rationale:
Tests: