fix(gh-address-comments): resolve script path and add CLI arguments #136
+205
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The skill referenced scripts/fetch_comments.py as a bare relative path, causing agents to look for it inside the target repo instead of the skill directory. This matches the pattern already used by gh-fix-ci. - SKILL.md: use <path-to-skill>/scripts/fetch_comments.py consistently - fetch_comments.py: add --repo, --pr, --json flags and working directory support so the script works when invoked from any location - openai.yaml: fix missing opening quote on short_description value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #96.
The
gh-address-commentsskill instructs agents to runscripts/fetch_comments.pyusing a bare relative path. Since agents execute from the target repository working directory (not the skill directory), the script is never found — forcing a fallback to raw GraphQL that loses the structured output the skill was designed around.The sibling skill
gh-fix-cialready solved this by using<path-to-skill>/scripts/...references. This PR alignsgh-address-commentsto the same pattern and adds the missing CLI interface.Changes
SKILL.md— Rewrote the workflow section to reference the script with the<path-to-skill>prefix, added a Quick start block and Bundled Resources documentation matching thegh-fix-ciconvention.scripts/fetch_comments.py— AddedargparseCLI with--repo,--pr, and--jsonflags. Allghandgitsubprocess calls now accept acwdparameter resolved from--repo, so the script works when invoked from any directory. Addedget_pr_ref_from_value()to resolve an explicit PR number or URL. Addedrender_text()for human-readable output (the default), with--jsonpreserving the original raw JSON dump.agents/openai.yaml— Fixed a missing opening quote on theshort_descriptionvalue (Address comments in a GitHub PR review"→"Address comments in a GitHub PR review").Test plan
--pr <number>and--pr <URL>both resolve correctly--jsonoutputs valid JSON to stdout